[AB-0002]: google auth configuration simplified #262
Conversation
|
@alexkucherenko is attempting to deploy a commit to the Listinai Team on Vercel. A member of the Team first needs to authorize it. |
OleksandrKucherenko
changed the title
|
Yeah i would like to solve the issue :) |
|
Hey @OleksandrKucherenko , a lot of these changes generally look good, but you're mixing a bunch of stuff up into a single PR. Could you please cherry pick the various changes into new branches and submit a PR per logical change, please? |
let's merge the PR #260 and than I will rebase this branch and it will make commits/changes much cleaner. |
|
As discussed on Discord, you're going to rebase this PR. |
OleksandrKucherenko
force-pushed
the
AB0002-google-auth-configuration
branch
from
3a82fb9
to
28572a4
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
OleksandrKucherenko
force-pushed
the
AB0002-google-auth-configuration
branch
3 times, most recently
from
c852d50
to
43fa27e
Compare
OleksandrKucherenko
force-pushed
the
AB0002-google-auth-configuration
branch
from
43fa27e
to
b88b97c
Compare
|
This is generally looking OK, but can you drop out the changes on .env.example, and just leave the commits on the Google provider to keep the PR clean please? |
|
@OleksandrKucherenko ping? |
Sorry, busy weeks... preparations for black friday and holidays... So again what stops you to merge?
|
What kind of change does this PR introduce?
Why was this change needed?
Should be rebased and merged after this PR: #260